Commit Graph

87 Commits

Author SHA1 Message Date
Ben Gilad a0d9f7532d Adding some missing incoming CallManager logic.
Change-Id: I0ce0218561a40de02313771e1f36b31914ad6eac
2014-02-26 13:37:13 -08:00
Ben Gilad bb167cdd0d Fix for a CallServiceRepository bug.
Specifically where stale call services are passed back
to the switchboard for processing, including upon no
call-service-provider implementations.

Change-Id: I1a5c26f22031e31f9a94b239f06d34619769a56f
2014-02-25 17:19:31 -08:00
Santos Cordon c80a98c130 Update test app to simulate incoming calls.
Change-Id: Ie6c4a371b5d264152dd0da048ad594205e5a33d3
2014-02-24 18:55:50 -08:00
Santos Cordon 83a4aa7d71 Merge "Adding answer/reject API support to Telecomm." into master-nova 2014-02-25 02:37:14 +00:00
Santos Cordon 61d0f70cf4 Adding answer/reject API support to Telecomm.
Adds answer/reject overridden methods to CallServiceWrapper.
Adds direct answer/reject to Call.java
Fills in existing answer/reject in CallsManager.java.

Change-Id: Ifd3a65230661b94f9dd99aabb2d2083684e2fc7c
2014-02-24 18:35:48 -08:00
Ben Gilad d239a03452 Remove dangling CallsManager code.
Change-Id: I964e817cb1be2769c7206138250c16df7ecd357e
2014-02-24 16:44:16 -08:00
Ben Gilad 487436bccf Remove dangling code in CallServiceProviderWrapper.
Change-Id: I5b4da5806074201b4b3a6522f8fba2e46b374220
2014-02-24 15:50:07 -08:00
Santos Cordon 5de168c920 Merge "Updating comments around provider cache." into master-nova 2014-02-24 20:37:49 +00:00
Sailesh Nepal 963c2344ca Merge "Fix making 2nd call" into master-nova 2014-02-24 20:23:55 +00:00
Ben Gilad b07a9d535c Fix an OutgoingCallProcessor bug.
Replacement for ag/422078 (now that master-nova is gone).

Change-Id: I45534c5fd13252218d2e151c318467db5e152717
2014-02-24 12:12:25 -08:00
Santos Cordon a12bc098b1 Updating comments around provider cache.
Change-Id: Iadfad5e107aa9f57a3b86981fcc07d8b3d06fc8c
2014-02-24 11:55:37 -08:00
Sailesh Nepal c319375074 Fix making 2nd call
Making more than one call didn't work. Problem was that
ServiceBinder.bind() wasn't correcly invoking the callback
if the service was already bound.

Bug: 13120050
Change-Id: I91179a436792221540b842f94a3d5564c517e02e
2014-02-22 14:25:03 -08:00
Santos Cordon 87bc6e6210 Merge "Change incoming call intent to be an activity intent." into master-nova 2014-02-22 00:30:13 +00:00
Santos Cordon 523f6058d4 Change incoming call intent to be an activity intent.
Change-Id: Ib8ed478a306e6efa474ad4c05a651cf651f76f8a
2014-02-21 14:14:46 -08:00
Evan Charlton a1c1708a8b Use the async CallServiceSelector API
Switch DummyCallServiceSelector to use the new CallServiceSelector API.

Change-Id: Ifc062cf49421079686d925406c823000232fa728
2014-02-21 20:57:42 +00:00
Sailesh Nepal fc511caf40 Mark call as active for InCallUI
Problem was that we weren't forwarding the state to the InCallController.

Bug: 13118741
Change-Id: I2a930da160e8171fb4d9c70cffe1660e77a71742
2014-02-21 03:12:09 +00:00
Sailesh Nepal 155ab5168a Fix disconnect button
Pressing disconnect wasn't working because Call.mCallService was being set to null.

Bug: 13119666
Change-Id: Ie79d52ad970e39879dc6e695172e2a28e28864d2
(cherry picked from commit be21aba2e97d783f44734d42c27e2506ec5217ac)
2014-02-21 02:27:47 +00:00
Ben Gilad ebd9b665a3 Remove dangling code and add a TODO to unify the incoming/outgoing approach to use startActivity.
Change-Id: I0c7fcd6a598dd858d57d37b77bb8c21202aa1249
2014-02-20 19:59:30 +00:00
Ben Gilad 37587237fc Update dangling references to #placeCall.
Change-Id: I68711ae4c50ac27f2d90da357e3106ca2d585f95
2014-02-19 16:03:44 -08:00
Ben Gilad c5b2269fe4 The packages/services/Telecomm counterpart of ag/420591.
Change-Id: I42ec26518d9391704fe5d0443867b00e635fc845
2014-02-19 14:54:04 -08:00
Santos Cordon e596c2bf80 Fix break.
Change-Id: I35830c0c3d7f1289871343e8f376a954922f4744
2014-02-18 21:08:23 -08:00
Santos Cordon cfcc2f7d82 Merge "Use the new incoming call confirmation APIs." into master-nova-dev 2014-02-19 04:36:23 +00:00
Santos Cordon 8d90ea69b2 Merge "Add IncomingCallsMangager to perform the incoming call sequence." into master-nova-dev 2014-02-19 04:36:17 +00:00
Santos Cordon 80d9bdcdd8 Add IncomingCallsMangager to perform the incoming call sequence.
IncomingCallsManager binds to the call service and asks it to confirm
the call. If the call service cannot be bound or it failed to confirm
within the timeout, we handle the incoming call as if it failed. The
code to do the actual confirmation is NYI.

Also add handleSuccess/Failed methods to Switchboard.
This still needs some changes to ICallService, ICallServiceAdapter, and
CallServiceWrapper before it will be fully functional.

Change-Id: Ibfd92ce17fb2054e2e0cb209738ad5375bf01492
2014-02-18 20:13:06 -08:00
Santos Cordon 7917d38176 Use the new incoming call confirmation APIs.
Update Telecomm and Telecomm test package to use the new
confirm-incoming-call APIs including confirmIncomingCall and
handleConfirmedIncomingCall.  Test call service always confirms all
incoming calls.

Also adds a list of unconfirmed incoming calls to the adapter. The
purpose of this is for the adapter to know which incoming call
confirmations to accept and which to ignore.

Change-Id: I914f25c45e5c887ca84d181d3dc173f25577e520
2014-02-18 20:08:28 -08:00
Evan Charlton abee48b001 Merge "Add a CallServiceSelector used for tests" into master-nova-dev 2014-02-19 02:33:51 +00:00
Sailesh Nepal 4039aaf916 Merge "Fix making outgoing calls" into master-nova-dev 2014-02-19 01:42:05 +00:00
Sailesh Nepal b6141aec99 Fix making outgoing calls
This CL fixes the following issues with outgoing calls:
  - Switchboard.placeOutgoingCall doesn't keep track of calls
  - ServiceBinder.bind calls setServiceInterface() multiple times if service is already bound
  - OutgoingCallProcessor.mCallServicesByInfo uses a custom object as a key which makes it impossible to look up call services
  - OutgoingCallProcessor.attemptNextCallService invokes CallServiceWrapper.call without binding first

Change-Id: Ia7983f52c8c03ed9aa44e2c52c20ce9c1c9c75de
2014-02-18 17:37:37 -08:00
Evan Charlton 23a0885e29 Add a CallServiceSelector used for tests
Change-Id: I292d962f1b73d0966af0c484ebddc724f8e6c925
2014-02-18 15:25:12 -08:00
Santos Cordon 4fa7ed1d5a Merge "Update the incoming call intent." into master-nova-dev 2014-02-18 07:34:59 +00:00
Santos Cordon de14ddb770 Add CallService to the manifest file.
Change-Id: I7f011d99775709be765f64eb0e54341d1a3fb31e
2014-02-17 23:31:55 -08:00
Santos Cordon 657cdd811b Update the incoming call intent.
Change the action name, extras, and comments around the intent.

Change-Id: I89e8dcf6e675f9b98d95656ea842c69954420041
2014-02-13 16:48:16 -08:00
Santos Cordon 29d295e35f Fix test code to use CallServiceInfo.
Change-Id: I085cfb4531571e2a712f9e7e66c782f4339bab74
2014-02-13 16:00:13 -08:00
Santos Cordon 5c12c6e001 Use BindCallback with ServiceBinder.bind().
Incoming calls sequence will need to know when the bind() succeeds so it
no longer makes sense for the wrapper objects to have direct references
to the finder.

Changes included:
- Making the handle* methods of ServiceBinder private implementations
  instead of astract.
- Add overriden setServiceInterface() to the wrapper.
- Add simple BindCallback interface used to get notified of bind()
  results.
- Update CallServiceRepository to use BindCallback.

Change-Id: I59300e16463e88626df6d055b7fd4be1d850c5f2
2014-02-13 15:54:38 -08:00
Santos Cordon c195e3613a Use CallServiceWrappers in place of ICallService.
Change-Id: Icd8a6ae2401f68d04b359fb7539b6d4f5aafecd5
2014-02-13 14:19:48 -08:00
Ben Gilad 76866be38d Merge "Following up on some TODOs etc." into master-nova-dev 2014-02-12 01:49:11 +00:00
Ben Gilad 13329fd858 Following up on some TODOs etc.
Change-Id: Ie5b11e85dd6415b89bb80791e0d3e834e77e35ca
2014-02-11 17:31:21 -08:00
Santos Cordon 63aeb16a14 Adding a CallService & CallServiceProvider concrete classes.
First step in no longer using ICallService and ICallServiceProviders
directly.
Adds a generic ServiceBinder class to manage binding/unbinding.

Change-Id: I7d26958dd85a99316dbd5e70caba3fd91d35911b
2014-02-11 16:36:30 -08:00
Santos Cordon 6242b13245 Dangling fixes for outgoing calls.
CallsManager.INSTANCE = new CallsManager() -> new Switchboard()

Except that Switchboard tries to use INSTANCE in it's own
constructor...which is yet not initialized.  Same problem with
InCallController.

Change-Id: Id0b6487e0e65ea3a90195392cbf1f3acc8c540ac
2014-02-07 17:00:40 -08:00
Santos Cordon 289d593896 Merge "Fully connect CallsManager with InCallController for outgoing calls." into master-nova-dev 2014-02-07 23:39:26 +00:00
Santos Cordon 049b7b6a8d Fully connect CallsManager with InCallController for outgoing calls.
Change-Id: Ic28fc5ea1e4a76be32fc7bd2d29f9690da959c96
2014-02-07 15:38:21 -08:00
Santos Cordon bd4d3b1062 Update TestCallService app to include a dummy selector.
Also some sprinkled fixes to get outgoing calls working.

Change-Id: I0fe34dfd42cbf75cc05f2a4ca4582a2052682143
2014-02-07 04:44:47 +00:00
Santos Cordon 681663d17b OutgoingCalls(1/6) - Filling in lifecycle of outgoing call.
This CL adds the following:
1. CallServiceAdapter implementation
2. Setting call-service adapters when the finder receives call services.
3. CallServiceAdapter notifies OutgoingCallManager/OCP about a successful
    outgoing call
4. Switchboard notifies CallsManager of the successful outgoing call
5. CallsManager adds the call to it's call repository.

What remains after this CL:
CallsManager sending the call to the InCall app and listening to
commands from in-call.

depends on: I086443e3f17ae0233b7b0fd5629119e989d06a40

Change-Id: I86f3e7ab02a47485eb2a5fb3557819418f3c4adf
2014-02-06 18:25:09 -08:00
Ben Gilad 2313e62356 Adding the switchboard ticker.
Change-Id: Ie4e144759b1e7f287104f002206de53a00c70216
2014-02-06 15:00:53 -08:00
Ben Gilad 8bdaa46255 Removing CallServiceUnavailableException that is no longer applicable.
Also including some cleanup in preparation for the next round of switchboard changes.

Change-Id: Ia8b293c971ff3866e4317eca4c9d053779917956
2014-02-06 09:58:36 -08:00
Evan Charlton 0120241e30 Enable proguard
Enable proguard for optimization (not obfuscation) to strip all of
the unnecessary methods, such as the majority of Guava.

Change-Id: Ic632ff6ae3b1a4c058090d843937867b3cde4447
2014-01-31 11:46:02 -08:00
Santos Cordon 0b03b4b143 Adding call state to the Call object.
Change-Id: I2369a040a41cc37488a23dda8a72d4456248ac62
2014-01-30 18:53:50 -08:00
Ben Gilad d983800e8f Merge "Wiring up the call from OutgoingCallProcessor to selectors." into master-nova-dev 2014-01-31 00:05:27 +00:00
Ben Gilad d88323b4e8 Wiring up the call from OutgoingCallProcessor to selectors.
Change-Id: Id8f4a88fd70d6c3801f7bcc6ed9f6f9f099950b6
2014-01-30 15:58:27 -08:00
Santos Cordon e3d76abbb6 Adding in-call service code.
Adding the in-call service binding code and the in-call adapter.

Change-Id: I034652001022ac26674096f2a91b09fe12e8fe1a
2014-01-29 18:09:56 -08:00