Remove dangling code and add a TODO to unify the incoming/outgoing approach to use startActivity.

Change-Id: I0c7fcd6a598dd858d57d37b77bb8c21202aa1249

src/com/android/telecomm/CallServiceRepository.java

@@ -154,14 +154,10 @@ final class CallServiceRepository {
         }
 
         int providerCount = providerNames.size();
-        int outstandingProviderCount = mOutstandingProviders.size();
+        Log.i(TAG, "Found " + providerCount + " implementations of ICallServiceProvider.");
 
-        Log.i(TAG, "Found " + providerCount + " implementations of ICallServiceProvider, "
-                + outstandingProviderCount + " of which are not currently processed.");
-
-        if (outstandingProviderCount == 0) {
-            // All known (provider) implementations are already processed, pass control
-            // back to the switchboard.
+        if (providerCount == 0) {
+            // Nothing to process, pass control back to the switchboard.
             updateSwitchboard();
         } else {
             // Schedule a lookup terminator to run after LOOKUP_TIMEOUT_MS milliseconds.

src/com/android/telecomm/IncomingCallsManager.java

@@ -56,7 +56,6 @@ final class IncomingCallsManager {
         mSwitchboard = switchboard;
     }
 
-
     /**
      * Confirms the existence of an incoming call with the specified call service (asynchronously).
      * Starts the timeout sequence in case the call service is unresponsive.

src/com/android/telecomm/Switchboard.java

@@ -119,8 +119,7 @@ final class Switchboard {
 
         mNewOutgoingCalls.add(call);
 
-        // We initialize a lookup every time because between calls the set of available call
-        // services can change between calls.
+        // Initiate a lookup every time to account for newly-installed apps and/or updated settings.
         mLookupId++;
         mCallServiceRepository.initiateLookup(mLookupId);
         mSelectorRepository.initiateLookup(mLookupId);

src/com/android/telecomm/TelecommReceiver.java

@@ -26,6 +26,9 @@ import com.google.common.base.Strings;
 
 /**
  * Receiver for public intents relating to Telecomm.
+ *
+ * TODO(gilad): Unify the incoming/outgoing approach to use startActivity in both cases thereby
+ * eliminating the incoming logic below, as well as this class as a whole.
  */
 public class TelecommReceiver extends BroadcastReceiver {