From ef2469e547eba588260458bdb51e89fd4d7fb90b Mon Sep 17 00:00:00 2001 From: Tom Cherry Date: Wed, 5 Jun 2019 10:27:41 -0700 Subject: [PATCH] base: fix out of date documentation with PropertySet() As of Android-P, __system_property_set() is synchronous and only will return '0' if the property was successfully set. Test: n/a Change-Id: Icbc0a6d8be1ae683565f378c534ea8e5c5f25357 --- base/include/android-base/properties.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/base/include/android-base/properties.h b/base/include/android-base/properties.h index 31e52731d..31823df0a 100644 --- a/base/include/android-base/properties.h +++ b/base/include/android-base/properties.h @@ -49,9 +49,6 @@ template T GetUintProperty(const std::string& key, T max = std::numeric_limits::max()); // Sets the system property `key` to `value`. -// Note that system property setting is inherently asynchronous so a return value of `true` -// isn't particularly meaningful, and immediately reading back the value won't necessarily -// tell you whether or not your call succeeded. A `false` return value definitely means failure. bool SetProperty(const std::string& key, const std::string& value); // Waits for the system property `key` to have the value `expected_value`.