From f10d4a15d2876d900c34bc8d9d784cd99371b413 Mon Sep 17 00:00:00 2001 From: Josh Gao Date: Thu, 17 Oct 2019 12:06:16 -0700 Subject: [PATCH] debuggerd_client_test: massively increase timeouts. debuggerd_client.race seems to have suddenly started to flake, for no apparent reason. This doesn't seem to reproduce locally, so increase the timeouts to rule out our test VMs being slow. Bug: http://b/142571257 Test: treehugger Change-Id: Ic54a78b8da36cb1163cec7e7976c73c3da628a30 --- debuggerd/client/debuggerd_client_test.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/debuggerd/client/debuggerd_client_test.cpp b/debuggerd/client/debuggerd_client_test.cpp index 9c2f0d632..2545cd6e5 100644 --- a/debuggerd/client/debuggerd_client_test.cpp +++ b/debuggerd/client/debuggerd_client_test.cpp @@ -73,15 +73,15 @@ TEST(debuggerd_client, race) { unique_fd pipe_read, pipe_write; ASSERT_TRUE(Pipe(&pipe_read, &pipe_write)); - // 64 kB should be enough for everyone. + // 64 MiB should be enough for everyone. constexpr int PIPE_SIZE = 64 * 1024 * 1024; ASSERT_EQ(PIPE_SIZE, fcntl(pipe_read.get(), F_SETPIPE_SZ, PIPE_SIZE)); // Wait for a bit to let the child spawn all of its threads. - std::this_thread::sleep_for(250ms); + std::this_thread::sleep_for(1s); ASSERT_TRUE( - debuggerd_trigger_dump(forkpid, kDebuggerdNativeBacktrace, 10000, std::move(pipe_write))); + debuggerd_trigger_dump(forkpid, kDebuggerdNativeBacktrace, 60000, std::move(pipe_write))); // Immediately kill the forked child, to make sure that the dump didn't return early. ASSERT_EQ(0, kill(forkpid, SIGKILL)) << strerror(errno);