From ae9749a29aae67897c22174bc15d2bf36700fbab Mon Sep 17 00:00:00 2001 From: Steven Moreland Date: Mon, 7 Oct 2019 17:37:22 -0700 Subject: [PATCH] libutils: flattenable deprecation comment This class isn't used very much and it isn't supported by AIDL. In order to recommend new users against this and recommend an alternative, added a comment here. Bug: 142282873 Test: N/A Change-Id: If7c6c9fac6c868ed6a515e658de752092d25d5f9 --- libutils/include/utils/Flattenable.h | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/libutils/include/utils/Flattenable.h b/libutils/include/utils/Flattenable.h index 9d006023d..953b85988 100644 --- a/libutils/include/utils/Flattenable.h +++ b/libutils/include/utils/Flattenable.h @@ -17,6 +17,9 @@ #ifndef ANDROID_UTILS_FLATTENABLE_H #define ANDROID_UTILS_FLATTENABLE_H +// DO NOT USE: please use parcelable instead +// This code is deprecated and will not be supported via AIDL code gen. For data +// to be sent over binder, please use parcelables. #include #include @@ -28,7 +31,9 @@ namespace android { - +// DO NOT USE: please use parcelable instead +// This code is deprecated and will not be supported via AIDL code gen. For data +// to be sent over binder, please use parcelables. class FlattenableUtils { public: template @@ -79,7 +84,9 @@ public: } }; - +// DO NOT USE: please use parcelable instead +// This code is deprecated and will not be supported via AIDL code gen. For data +// to be sent over binder, please use parcelables. /* * The Flattenable protocol allows an object to serialize itself out * to a byte-buffer and an array of file descriptors. @@ -131,6 +138,9 @@ inline status_t Flattenable::unflatten( return static_cast(this)->T::unflatten(buffer, size, fds, count); } +// DO NOT USE: please use parcelable instead +// This code is deprecated and will not be supported via AIDL code gen. For data +// to be sent over binder, please use parcelables. /* * LightFlattenable is a protocol allowing object to serialize themselves out * to a byte-buffer. Because it doesn't handle file-descriptors, @@ -171,6 +181,9 @@ inline status_t LightFlattenable::unflatten(void const* buffer, size_t size) return static_cast(this)->T::unflatten(buffer, size); } +// DO NOT USE: please use parcelable instead +// This code is deprecated and will not be supported via AIDL code gen. For data +// to be sent over binder, please use parcelables. /* * LightFlattenablePod is an implementation of the LightFlattenable protocol * for POD (plain-old-data) objects.