pa-fazil
/
android_system_core
mirror of https://github.com/fazilsheik96/android_system_core.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Avoid leaking property values into logs on error 

The purpose of having fine grain read/write control over the property
space is to help ensure the confidentiality of data stored in
properties. Leaking property values into the dmesg buffer on errors
exposes the value outside of the access control rules specified by
policy.

(arguably this is also true for the property name, not just the value.
However, property names are exposed in other places now, so the
incentive to fix this is lower. It would also take away a valuable
debugging tool.)

Test: compiles
Change-Id: I4a0634b8b5e4fd2edf718eaf7343940df627366d
This commit is contained in:
Nick Kralevich 2019-04-04 10:10:01 -07:00
parent 744677aaf5
commit 9ca898fff8
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
init/property_service.cpp
View File

@ -557,9 +557,8 @@ static void handle_property_set_fd() {
uint32_t result = uint32_t result =
HandlePropertySet(prop_name, prop_value, socket.source_context(), cr, &error); HandlePropertySet(prop_name, prop_value, socket.source_context(), cr, &error);
if (result != PROP_SUCCESS) { if (result != PROP_SUCCESS) {
LOG(ERROR) << "Unable to set property '" << prop_name << "' to '" << prop_value LOG(ERROR) << "Unable to set property '" << prop_name << "' from uid:" << cr.uid
<< "' from uid:" << cr.uid << " gid:" << cr.gid << " pid:" << cr.pid << ": " << " gid:" << cr.gid << " pid:" << cr.pid << ": " << error;
<< error;
} }
break; break;
@ -579,9 +578,8 @@ static void handle_property_set_fd() {
std::string error; std::string error;
uint32_t result = HandlePropertySet(name, value, socket.source_context(), cr, &error); uint32_t result = HandlePropertySet(name, value, socket.source_context(), cr, &error);
if (result != PROP_SUCCESS) { if (result != PROP_SUCCESS) {
LOG(ERROR) << "Unable to set property '" << name << "' to '" << value LOG(ERROR) << "Unable to set property '" << name << "' from uid:" << cr.uid
<< "' from uid:" << cr.uid << " gid:" << cr.gid << " pid:" << cr.pid << ": " << " gid:" << cr.gid << " pid:" << cr.pid << ": " << error;
<< error;
} }
socket.SendUint32(result); socket.SendUint32(result);
break; break;