From 5a141424e660165122f2ab40f28cd4af3bc96833 Mon Sep 17 00:00:00 2001
From: Vic Yang <victoryang@google.com>
Date: Fri, 27 Sep 2019 21:03:09 -0700
Subject: [PATCH] Fix memory leak in String16

Newly allocated SharedBuffer already has reference count 1, so we
should not call acquire().

Bug: 141764153
Test: Run String16Test.* with ASan that was able to detect the leak
      without this change.
Change-Id: Ib8b1b707b028386d717414d8c5ec5ea7b4b59464
---
 libutils/String16.cpp | 2 --
 1 file changed, 2 deletions(-)

diff --git a/libutils/String16.cpp b/libutils/String16.cpp
index 5c3cf3261..e2a8c59a0 100644
--- a/libutils/String16.cpp
+++ b/libutils/String16.cpp
@@ -346,7 +346,6 @@ void* String16::edit() {
     if (isStaticString()) {
         buf = static_cast<SharedBuffer*>(alloc((size() + 1) * sizeof(char16_t)));
         if (buf) {
-            buf->acquire();
             memcpy(buf->data(), mString, (size() + 1) * sizeof(char16_t));
         }
     } else {
@@ -365,7 +364,6 @@ void* String16::editResize(size_t newSize) {
         }
         buf = static_cast<SharedBuffer*>(alloc(newSize));
         if (buf) {
-            buf->acquire();
             memcpy(buf->data(), mString, copySize);
         }
     } else {