pa-fazil
/
android_system_core
mirror of https://github.com/fazilsheik96/android_system_core.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

libutils: add unit tests for invalid utf-8 and utf-16 strings 

Characters get dropped during the conversionis between 8 and 16.

Test: atest libutils_test
Change-Id: Ie76dd38e97968137555ba2ab7ce188c9122ed06e
This commit is contained in:
Devin Moore 2020-10-21 17:25:42 -07:00 committed by Steven Moreland
parent dd5184f858
commit 6bcbeeafba
2 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
libutils/String16_test.cpp
View File

@ -215,4 +215,16 @@ TEST(String16Test, EmptyStringIsStatic) {
EXPECT_TRUE(tmp.isStaticString()); EXPECT_TRUE(tmp.isStaticString());
} }
TEST(String16Test, OverreadUtf8Conversion) {
char tmp[] = {'a', static_cast<char>(0xe0), '\0'};
String16 another(tmp);
EXPECT_TRUE(another.size() == 0);
}
TEST(String16Test, ValidUtf8Conversion) {
String16 another("abcdef");
EXPECT_EQ(6U, another.size());
EXPECT_STR16EQ(another, u"abcdef");
}
} // namespace android } // namespace android

5
libutils/String8_test.cpp
View File

@ -96,4 +96,9 @@ TEST_F(String8Test, CheckUtf32Conversion) {
EXPECT_EQ(10U, string8.length()); EXPECT_EQ(10U, string8.length());
} }
TEST_F(String8Test, ValidUtf16Conversion) {
char16_t tmp[] = u"abcdef";
String8 valid = String8(String16(tmp));
EXPECT_STREQ(valid, "abcdef");
}
} }