pa-fazil
/
android_system_core
mirror of https://github.com/fazilsheik96/android_system_core.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Added test for version check 

Test: fastboot_test
Bug: 194686221
Change-Id: I886c0a91be3b4f4bf7f2b8c76704aa30a352ee5b
This commit is contained in:
Daniel Zheng 2023-04-13 11:39:26 -07:00
parent 76aa257850
commit 68b84df994
2 changed files with 19 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
fastboot/fastboot.h
View File

@ -133,6 +133,7 @@ void syntax_error(const char* fmt, ...);
std::string get_current_slot(); std::string get_current_slot();
// Code for Parsing fastboot-info.txt // Code for Parsing fastboot-info.txt
bool CheckFastbootInfoRequirements(const std::vector<std::string>& command);
std::unique_ptr<FlashTask> ParseFlashCommand(const FlashingPlan* fp, std::unique_ptr<FlashTask> ParseFlashCommand(const FlashingPlan* fp,
const std::vector<std::string>& parts); const std::vector<std::string>& parts);
std::unique_ptr<RebootTask> ParseRebootCommand(const FlashingPlan* fp, std::unique_ptr<RebootTask> ParseRebootCommand(const FlashingPlan* fp,

18
fastboot/task_test.cpp
View File

@ -80,3 +80,21 @@ TEST_F(ParseTest, CORRECT_FlASH_TASK_FORMED) {
ASSERT_EQ(task->GetImageName(), expected_values[i][3]); ASSERT_EQ(task->GetImageName(), expected_values[i][3]);
} }
} }
TEST_F(ParseTest, VERSION_CHECK_CORRRECT) {
std::vector<std::string> correct_versions = {
"version 1.0",
"version 22.00",
};
std::vector<std::string> bad_versions = {"version", "version .01", "version x1",
"version 1.0.1", "version 1.", "s 1.0",
"version 1.0 2.0"};
for (auto& version : correct_versions) {
ASSERT_TRUE(CheckFastbootInfoRequirements(android::base::Split(version, " "))) << version;
}
for (auto& version : bad_versions) {
ASSERT_FALSE(CheckFastbootInfoRequirements(android::base::Split(version, " "))) << version;
}
}