From 3f67fb8e45662bc993bd34a7b6d155c44c9ebc7d Mon Sep 17 00:00:00 2001 From: Tom Cherry Date: Fri, 10 Apr 2020 10:08:24 -0700 Subject: [PATCH] init: fix todo in a test Structured bindings with templated containers work now, so no need for the workaround or TODO. Test: init unit tests Change-Id: I6a286de9859d8a97df480a7ac2862a3a10bd9fb3 --- init/ueventd_test.cpp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/init/ueventd_test.cpp b/init/ueventd_test.cpp index 2d7d2f819..fc3cdfb7d 100644 --- a/init/ueventd_test.cpp +++ b/init/ueventd_test.cpp @@ -53,11 +53,7 @@ void WriteFromMultipleThreads(std::vector>& files_and_ }; std::vector threads; - // TODO(b/63712782): Structured bindings + templated containers are broken in clang :( - // for (const auto& [file, parameter] : files_and_parameters) { - for (const auto& pair : files_and_parameters) { - const auto& file = pair.first; - const auto& parameter = pair.second; + for (const auto& [file, parameter] : files_and_parameters) { threads.emplace_back(std::thread(make_thread_function(file, parameter))); }