From 31f7df5fd1016ccfdec6ba9d65cd296861b2c40f Mon Sep 17 00:00:00 2001 From: Mark Salyzyn Date: Fri, 13 Mar 2015 15:57:11 -0700 Subject: [PATCH] liblog: reject empty logging messages A regression after "liblog: Instrument logging of logd write drops" where an empty payload would result in an insufficient iovec to report the write drop. Change-Id: Iffabcfbb0680898d7a42004700e638e9d940ff5f --- liblog/logd_write.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/liblog/logd_write.c b/liblog/logd_write.c index a8650938f..8f8cc3fd5 100644 --- a/liblog/logd_write.c +++ b/liblog/logd_write.c @@ -178,6 +178,10 @@ static int __write_to_log_daemon(log_id_t log_id, struct iovec *vec, size_t nr) static pid_t last_pid = (pid_t) -1; static atomic_int_fast32_t dropped; + if (!nr) { + return -EINVAL; + } + if (last_uid == AID_ROOT) { /* have we called to get the UID yet? */ last_uid = getuid(); }