2020-05-12 19:46:43 +00:00
|
|
|
/*
|
|
|
|
* Copyright (C) 2020 The Android Open Source Project
|
|
|
|
*
|
|
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
* you may not use this file except in compliance with the License.
|
|
|
|
* You may obtain a copy of the License at
|
|
|
|
*
|
|
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
*
|
|
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
* See the License for the specific language governing permissions and
|
|
|
|
* limitations under the License.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#pragma once
|
|
|
|
|
|
|
|
#include <atomic>
|
|
|
|
#include <list>
|
|
|
|
#include <mutex>
|
|
|
|
|
|
|
|
#include "LogBuffer.h"
|
|
|
|
#include "LogBufferElement.h"
|
|
|
|
#include "LogReaderList.h"
|
|
|
|
#include "LogStatistics.h"
|
|
|
|
#include "LogTags.h"
|
|
|
|
#include "rwlock.h"
|
|
|
|
|
|
|
|
class SimpleLogBuffer : public LogBuffer {
|
|
|
|
public:
|
|
|
|
SimpleLogBuffer(LogReaderList* reader_list, LogTags* tags, LogStatistics* stats);
|
|
|
|
~SimpleLogBuffer();
|
2020-06-17 18:40:55 +00:00
|
|
|
void Init() override final;
|
2020-05-12 19:46:43 +00:00
|
|
|
|
|
|
|
int Log(log_id_t log_id, log_time realtime, uid_t uid, pid_t pid, pid_t tid, const char* msg,
|
|
|
|
uint16_t len) override;
|
2020-05-28 19:38:21 +00:00
|
|
|
std::unique_ptr<FlushToState> CreateFlushToState(uint64_t start, LogMask log_mask) override;
|
|
|
|
bool FlushTo(LogWriter* writer, FlushToState& state,
|
|
|
|
const std::function<FilterResult(log_id_t log_id, pid_t pid, uint64_t sequence,
|
logd: move leading_dropped logic into FlushTo()
This logic isn't generic, so it should not be in the generic
LogReaderThread.
Moreover, it's currently broken in essentially every case except when
filtering by UID, because it runs as in the filter functions before
the actual filtering by pid/etc takes place. For example, when
filtering by pid, it's possible to get leading chatty messages. The
newly added test was failing previously but is fixed by this change.
It's fundamentally broken in the tail case. Take this example:
1: Normal message
2: Chatty message
3: Normal message
4: Normal message
If you read that log buffer with a tail value of 3, there are three
possible outcomes:
1) Messages #2-4, however this would include a leading chatty message,
which is not allowed.
2) Messages #3-4, however this is only 2, not 3 messages.
3) Messages #1-4, however this is 4, more than the 3 requested
messages.
This code chooses 2) as the correct solution, in this case, we don't
need to account for leading chatty messages when counting the total
logs in the buffer. A test is added for this case as well.
Test: new unit test
Change-Id: Id02eb81a8e77390aba4f85aac659c6cab498dbcd
2020-05-29 03:02:42 +00:00
|
|
|
log_time realtime)>& filter) override;
|
2020-05-12 19:46:43 +00:00
|
|
|
|
|
|
|
bool Clear(log_id_t id, uid_t uid) override;
|
|
|
|
unsigned long GetSize(log_id_t id) override;
|
2020-06-17 18:40:55 +00:00
|
|
|
int SetSize(log_id_t id, unsigned long size) override final;
|
2020-05-12 19:46:43 +00:00
|
|
|
|
|
|
|
uint64_t sequence() const override { return sequence_.load(std::memory_order_relaxed); }
|
|
|
|
|
|
|
|
protected:
|
|
|
|
virtual bool Prune(log_id_t id, unsigned long prune_rows, uid_t uid) REQUIRES(lock_);
|
|
|
|
virtual void LogInternal(LogBufferElement&& elem) REQUIRES(lock_);
|
|
|
|
|
|
|
|
// Returns an iterator to the oldest element for a given log type, or logs_.end() if
|
|
|
|
// there are no logs for the given log type. Requires logs_lock_ to be held.
|
|
|
|
std::list<LogBufferElement>::iterator GetOldest(log_id_t log_id) REQUIRES(lock_);
|
|
|
|
std::list<LogBufferElement>::iterator Erase(std::list<LogBufferElement>::iterator it)
|
|
|
|
REQUIRES(lock_);
|
|
|
|
void KickReader(LogReaderThread* reader, log_id_t id, unsigned long prune_rows)
|
|
|
|
REQUIRES_SHARED(lock_);
|
|
|
|
|
|
|
|
LogStatistics* stats() { return stats_; }
|
|
|
|
LogReaderList* reader_list() { return reader_list_; }
|
|
|
|
unsigned long max_size(log_id_t id) REQUIRES_SHARED(lock_) { return max_size_[id]; }
|
|
|
|
std::list<LogBufferElement>& logs() { return logs_; }
|
|
|
|
|
|
|
|
RwLock lock_;
|
|
|
|
|
|
|
|
private:
|
|
|
|
bool ShouldLog(log_id_t log_id, const char* msg, uint16_t len);
|
|
|
|
void MaybePrune(log_id_t id) REQUIRES(lock_);
|
|
|
|
|
|
|
|
LogReaderList* reader_list_;
|
|
|
|
LogTags* tags_;
|
|
|
|
LogStatistics* stats_;
|
|
|
|
|
|
|
|
std::atomic<uint64_t> sequence_ = 1;
|
|
|
|
|
|
|
|
unsigned long max_size_[LOG_ID_MAX] GUARDED_BY(lock_);
|
|
|
|
std::list<LogBufferElement> logs_ GUARDED_BY(lock_);
|
|
|
|
// Keeps track of the iterator to the oldest log message of a given log type, as an
|
|
|
|
// optimization when pruning logs. Use GetOldest() to retrieve.
|
|
|
|
std::optional<std::list<LogBufferElement>::iterator> oldest_[LOG_ID_MAX] GUARDED_BY(lock_);
|
|
|
|
};
|