pa-fazil
/
android_packages_services_Telecomm
mirror of https://github.com/fazilsheik96/android_packages_services_Telecomm.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix dark navigationBar background in some telephony settings pages 

Style changes:

- Organize styles.xml, make Theme.Telecom.DialerSettings as a base settings theme, and declare navigationBarColor transparent.

- Align EnableAccount\BlockedNumbers\CallSettingsWithoutDividerTheme extending this base settings theme.

Affected pages:
EnableAccountPreferenceActivity\RespondViaSmsSettings\BlockedNumbersActivity

Bug: b/253168764 b/236809093
Test: Manual UI test in normal and dark mode

Change-Id: Iced178b2edfeb5a6f8d2bb6048b353e38981fb97
This commit is contained in:
Shen Lin 2022-10-12 16:11:24 +08:00
parent 6a1a54a926
commit e34d7138f1
2 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
AndroidManifest.xml
View File

@ -276,7 +276,7 @@
<activity android:name=".settings.EnableAccountPreferenceActivity"
android:label="@string/enable_account_preference_title"
android:configChanges="orientation|screenSize|keyboardHidden"
android:theme="@style/Theme.Telecom.DialerSettings"
android:theme="@style/Theme.Telecom.EnableAccount"
android:process=":ui"
android:exported="true">
<intent-filter>

16
res/values/styles.xml
View File

@ -29,19 +29,21 @@
<style name="Theme.Telecom.DialerSettings" parent="@android:style/Theme.DeviceDefault.Light">
<item name="android:forceDarkAllowed">true</item>
<item name="android:actionBarStyle">@style/TelecomDialerSettingsActionBarStyle</item>
<item name="android:actionOverflowButtonStyle">@style/TelecomDialerSettingsActionOverflowButtonStyle</item>
<item name="android:navigationBarColor">@android:color/transparent</item>
<item name="android:windowLightStatusBar">true</item>
<item name="android:windowLightNavigationBar">true</item>
</style>
<style name="Theme.Telecom.EnableAccount" parent="Theme.Telecom.DialerSettings">
<item name="android:actionOverflowButtonStyle">
@style/TelecomDialerSettingsActionOverflowButtonStyle
</item>
<item name="android:windowContentOverlay">@null</item>
</style>
<style name="Theme.Telecom.BlockedNumbers" parent="@android:style/Theme.DeviceDefault.Light">
<item name="android:forceDarkAllowed">true</item>
<item name="android:actionBarStyle">@style/TelecomDialerSettingsActionBarStyle</item>
<item name="android:windowLightStatusBar">true</item>
<item name="android:windowLightNavigationBar">true</item>
<item name="android:windowContentOverlay">@null</item>
<style name="Theme.Telecom.BlockedNumbers" parent="Theme.Telecom.DialerSettings">
<item name="android:listDivider">@null</item>
<item name="android:windowContentOverlay">@null</item>
</style>
<style name="TelecomDialerSettingsActionBarStyle" parent="android:Widget.DeviceDefault.ActionBar">