Commit Graph

9 Commits

Author SHA1 Message Date
Inseob Kim d25e2aa990 Remove checkstyle_hook
Because it conflicts with google_java_format hook.

Test: manual
Change-Id: I83da1c2691657f664529e6d2f5d665be883dbd84
2022-12-12 02:29:39 +00:00
Alice Wang 6e646f1e0e [linter] Add google-java-format as java pre-commit linter
Test: CL gets uploaded.
Change-Id: I084c321605398acf727161d7a3929d0ddac5de5e
2022-11-14 15:59:16 +00:00
Alan Stokes 644306cdfa Remove google-java-format hook
We're trying to follow Android framework style, not Google style.

Occasionally google-java-format and checkstyle disagree, so get rid of
the one we don't need.

Test: CL that was causing problems uploads cleanly.
Change-Id: Ic1653234fc928d8d171aae6a7a2a2e897ae59344
2021-11-23 11:39:53 +00:00
David Brazdil cf3270b302 Enable google_java_format in PREUPLOAD.cfg
By popular demand, enable Java linter preupload hook.

Test: repo upload -n
Change-Id: I63b3fe4b09e0ee5329b29fed6840aff2929a32c1
2021-03-11 16:53:45 +00:00
David Brazdil 850e24f109 Enable more linters in PREUPLOAD.cfg
Test: `repo upload -n` on a failing commit
Change-Id: I5e26ffec1f6f17dcfe056addefb2ee61c0905103
2021-03-11 11:11:55 +00:00
Andrew Scull 11e6a29a98 Add style hooks for blueprint and java files
Test: N/A
Change-Id: I0ead4b81173bd4734d4044c9c3ab499c1e5fc9d3
2020-10-19 14:45:11 +01:00
Andrew Scull c09e225aac Enable clang-format preupload hook
Some components may have to fall back on C/C++, enable format checking
for them.

Test: N/A
Change-Id: I81caa73457c0eb6846d1621fcdeffced1207bff6
2020-10-19 13:22:17 +01:00
Andrew Scull 89330a04ac Add preupload hook to encourage submission to AOSP
Where possible, development should happen in AOSP so add a hook to
remind developers of this if it looks like they're trying to do
something else.

Test: N/A
Change-Id: I211de2daad2b67a3008e40043bb2da941d13548b
2020-10-13 14:03:24 +01:00
Andrew Scull 3a5ad753d7 Enable rust formatting preupload hooks
The rustfmt configuration is linked to the default from
build/soong/scripts.

Bug: 157146658
Test: tried uploading badly and correctly formatted rust
Change-Id: Ie104cca1c9f309e4b46acdfabd8c2e17c35180ad
2020-10-13 12:23:13 +01:00