pa-fazil
/
android_packages_modules_Virtualization
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Telemetry] Include (compos) job cancellation reason 

Job scheduler sometimes cancels the compos job, in which case,
getStopReason() will give the reason, by default it returns
STOP_REASON_UNDEFINED.

Test: build suceeded
Bug: 234151510
Change-Id: I10f29db6f45d8e9423b498d45769f39755c791fb
This commit is contained in:
Shikha Panwar 2022-06-06 12:39:47 +00:00
parent 7a13b3fc9a
commit 852629dccb
2 changed files with 16 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
compos/service/java/com/android/server/compos/IsolatedCompilationJobService.java
View File

@ -204,7 +204,7 @@ public class IsolatedCompilationJobService extends JobService {
Log.w(TAG, "Failed to cancel CompilationTask", e); Log.w(TAG, "Failed to cancel CompilationTask", e);
} }
mMetrics.onCompilationEnded(IsolatedCompilationMetrics.RESULT_JOB_CANCELED); mMetrics.onCompilationJobCanceled(mParams.getStopReason());
try { try {
task.asBinder().unlinkToDeath(this, 0); task.asBinder().unlinkToDeath(this, 0);
} catch (NoSuchElementException e) { } catch (NoSuchElementException e) {

19
compos/service/java/com/android/server/compos/IsolatedCompilationMetrics.java
View File

@ -17,6 +17,7 @@
package com.android.server.compos; package com.android.server.compos;
import android.annotation.IntDef; import android.annotation.IntDef;
import android.app.job.JobParameters;
import android.os.SystemClock; import android.os.SystemClock;
import android.util.Log; import android.util.Log;
@ -76,7 +77,6 @@ class IsolatedCompilationMetrics {
private long mCompilationStartTimeMs = 0; private long mCompilationStartTimeMs = 0;
public static void onCompilationScheduled(@ScheduleJobResult int result) { public static void onCompilationScheduled(@ScheduleJobResult int result) {
// TODO(b/218525257): write to ArtStatsLog instead of logcat
ArtStatsLog.write(ArtStatsLog.ISOLATED_COMPILATION_SCHEDULED, result); ArtStatsLog.write(ArtStatsLog.ISOLATED_COMPILATION_SCHEDULED, result);
Log.i(TAG, "ISOLATED_COMPILATION_SCHEDULED: " + result); Log.i(TAG, "ISOLATED_COMPILATION_SCHEDULED: " + result);
} }
@ -85,13 +85,24 @@ class IsolatedCompilationMetrics {
mCompilationStartTimeMs = SystemClock.elapsedRealtime(); mCompilationStartTimeMs = SystemClock.elapsedRealtime();
} }
public void onCompilationJobCanceled(@JobParameters.StopReason int jobStopReason) {
statsLogPostCompilation(RESULT_JOB_CANCELED, jobStopReason);
}
public void onCompilationEnded(@CompilationResult int result) { public void onCompilationEnded(@CompilationResult int result) {
statsLogPostCompilation(result, JobParameters.STOP_REASON_UNDEFINED);
}
private void statsLogPostCompilation(@CompilationResult int result,
@JobParameters.StopReason int jobStopReason) {
long compilationTime = mCompilationStartTimeMs == 0 ? -1 long compilationTime = mCompilationStartTimeMs == 0 ? -1
: SystemClock.elapsedRealtime() - mCompilationStartTimeMs; : SystemClock.elapsedRealtime() - mCompilationStartTimeMs;
mCompilationStartTimeMs = 0; mCompilationStartTimeMs = 0;
// TODO(b/218525257): write to ArtStatsLog instead of logcat ArtStatsLog.write(ArtStatsLog.ISOLATED_COMPILATION_ENDED, compilationTime,
ArtStatsLog.write(ArtStatsLog.ISOLATED_COMPILATION_ENDED, compilationTime, result); result, jobStopReason);
Log.i(TAG, "ISOLATED_COMPILATION_ENDED: " + result + ", " + compilationTime); Log.i(TAG, "ISOLATED_COMPILATION_ENDED: " + result + ", " + compilationTime
+ ", " + jobStopReason);
} }
} }