From 74c7561dcc3bd8fb0cdcc9ad6a7e321ab4e69f9f Mon Sep 17 00:00:00 2001 From: Colin Cross Date: Mon, 22 Jun 2020 11:20:23 -0700 Subject: [PATCH 1/2] Use inclusive language in build/make part 2 Test: m checkbuild Bug: 158889297 Change-Id: I63bac680cc63a8564f35ae85dda1a0b09c9fd541 Merged-In: I63bac680cc63a8564f35ae85dda1a0b09c9fd541 (cherry picked from commit d1cbfeaa3a0cf0083fc6cf1e070d646f56c0eecf) --- core/config.mk | 1 + core/main.mk | 3 +-- core/product.mk | 1 - 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/core/config.mk b/core/config.mk index 0b9ff52bcf..90eea5ba99 100644 --- a/core/config.mk +++ b/core/config.mk @@ -123,6 +123,7 @@ $(KATI_obsolete_var MD5SUM) $(KATI_obsolete_var BOARD_HAL_STATIC_LIBRARIES, See $(CHANGES_URL)#BOARD_HAL_STATIC_LIBRARIES) $(KATI_obsolete_var LOCAL_HAL_STATIC_LIBRARIES, See $(CHANGES_URL)#BOARD_HAL_STATIC_LIBRARIES) $(KATI_obsolete_var PRODUCT_ARTIFACT_SYSTEM_CERTIFICATE_REQUIREMENT_WHITELIST,Use PRODUCT_ARTIFACT_SYSTEM_CERTIFICATE_REQUIREMENT_ALLOW_LIST.) +$(KATI_obsolete_var PRODUCT_ARTIFACT_PATH_REQUIREMENT_WHITELIST,Use PRODUCT_ARTIFACT_PATH_REQUIREMENT_ALLOWED_LIST.) # Used to force goals to build. Only use for conditionally defined goals. .PHONY: FORCE diff --git a/core/main.mk b/core/main.mk index a7a69f086e..9e1d6b7024 100644 --- a/core/main.mk +++ b/core/main.mk @@ -1218,8 +1218,7 @@ $(call dist-for-goals,droidcore,$(CERTIFICATE_VIOLATION_MODULES_FILENAME)) $(eval extra_files := $(filter-out $(files) $(HOST_OUT)/%,$(product_target_FILES))) \ $(eval files_in_requirement := $(filter $(path_patterns),$(extra_files))) \ $(eval all_offending_files += $(files_in_requirement)) \ - $(eval allowed := $(strip $(PRODUCT_ARTIFACT_PATH_REQUIREMENT_WHITELIST) \ - $(PRODUCT_ARTIFACT_PATH_REQUIREMENT_ALLOWED_LIST))) \ + $(eval allowed := $(PRODUCT_ARTIFACT_PATH_REQUIREMENT_ALLOWED_LIST)) \ $(eval allowed_patterns := $(call resolve-product-relative-paths,$(allowed))) \ $(eval offending_files := $(filter-out $(allowed_patterns),$(files_in_requirement))) \ $(eval enforcement := $(PRODUCT_ENFORCE_ARTIFACT_PATH_REQUIREMENTS)) \ diff --git a/core/product.mk b/core/product.mk index 3d96d23590..f8ba5936f8 100644 --- a/core/product.mk +++ b/core/product.mk @@ -333,7 +333,6 @@ _product_single_value_vars += PRODUCT_ENFORCE_ARTIFACT_PATH_REQUIREMENTS _product_single_value_vars += PRODUCT_ENFORCE_ARTIFACT_SYSTEM_CERTIFICATE_REQUIREMENT _product_list_vars += PRODUCT_ARTIFACT_SYSTEM_CERTIFICATE_REQUIREMENT_ALLOW_LIST _product_list_vars += PRODUCT_ARTIFACT_PATH_REQUIREMENT_HINT -_product_list_vars += PRODUCT_ARTIFACT_PATH_REQUIREMENT_WHITELIST _product_list_vars += PRODUCT_ARTIFACT_PATH_REQUIREMENT_ALLOWED_LIST # List of modules that should be forcefully unmarked from being LOCAL_PRODUCT_MODULE, and hence From e6369cec6bcc28e528884ab3ba32ae560dab26dc Mon Sep 17 00:00:00 2001 From: Tianjie Date: Wed, 24 Jun 2020 11:20:36 -0700 Subject: [PATCH 2/2] Add lz4 to otatools A call to lz4 was added in http://go/aog/1329115. But the binary isn't added to otatools, leading to a signing failure. Bug: 159656873 Test: build otatools Change-Id: I9cab00f36ce3c39cc174b4c9feffdf360f0364ef (cherry picked from commit 3031c29905072053e686aa11f4e35c4932b4174a) --- core/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/core/Makefile b/core/Makefile index ea4a745992..f0b196a2e0 100644 --- a/core/Makefile +++ b/core/Makefile @@ -4100,6 +4100,7 @@ INTERNAL_OTATOOLS_MODULES := \ libconscrypt_openjdk_jni \ lpmake \ lpunpack \ + lz4 \ make_f2fs \ merge_target_files \ minigzip \