diff --git a/libc/bionic/ndk_cruft.cpp b/libc/bionic/ndk_cruft.cpp index b9153820d..b0346d418 100644 --- a/libc/bionic/ndk_cruft.cpp +++ b/libc/bionic/ndk_cruft.cpp @@ -29,6 +29,7 @@ // This file perpetuates the mistakes of the past, but only for 32-bit targets. #if !defined(__LP64__) +#include #include #include #include @@ -73,4 +74,17 @@ extern "C" void memswap(void* m1, void* m2, size_t n) { } } +extern "C" int pthread_attr_setstackaddr(pthread_attr_t*, void*) { + // This was removed from POSIX.1-2008, and is not implemented on bionic. + // Needed for ABI compatibility with the NDK. + return ENOSYS; +} + +extern "C" int pthread_attr_getstackaddr(const pthread_attr_t* attr, void** stack_addr) { + // This was removed from POSIX.1-2008. + // Needed for ABI compatibility with the NDK. + *stack_addr = (char*)attr->stack_base + attr->stack_size; + return 0; +} + #endif diff --git a/libc/bionic/pthread_attr.cpp b/libc/bionic/pthread_attr.cpp index d597c7e29..e1cd85365 100644 --- a/libc/bionic/pthread_attr.cpp +++ b/libc/bionic/pthread_attr.cpp @@ -94,22 +94,6 @@ int pthread_attr_getstacksize(const pthread_attr_t* attr, size_t* stack_size) { return 0; } -#if !defined(__LP64__) -// TODO: this exists only for backward binary compatibility on 32 bit platforms. -extern "C" int pthread_attr_setstackaddr(pthread_attr_t*, void*) { - // This was removed from POSIX.1-2008, and is not implemented on bionic. - // Needed for ABI compatibility with the NDK. - return ENOSYS; -} - -extern "C" int pthread_attr_getstackaddr(const pthread_attr_t* attr, void** stack_addr) { - // This was removed from POSIX.1-2008. - // Needed for ABI compatibility with the NDK. - *stack_addr = (char*)attr->stack_base + attr->stack_size; - return 0; -} -#endif // !defined(__LP64__) - int pthread_attr_setstack(pthread_attr_t* attr, void* stack_base, size_t stack_size) { if ((stack_size & (PAGE_SIZE - 1) || stack_size < PTHREAD_STACK_MIN)) { return EINVAL; diff --git a/libc/include/pthread.h b/libc/include/pthread.h index a2a67892d..f93f9e9bf 100644 --- a/libc/include/pthread.h +++ b/libc/include/pthread.h @@ -234,10 +234,6 @@ extern void __pthread_cleanup_pop(__pthread_cleanup_t*, int); #if !defined(__LP64__) -/* Deprecated by POSIX. TODO: support for LP64 but add deprecated attribute instead? */ -int pthread_attr_getstackaddr(const pthread_attr_t*, void**) __nonnull((1, 2)); /* deprecated */ -int pthread_attr_setstackaddr(pthread_attr_t*, void*) __nonnull((1)); /* deprecated */ - // Bionic additions that are deprecated even in the 32-bit ABI. // // TODO: Remove them once chromium_org / NFC have switched over.