pa-fazil
/
android_bionic
mirror of https://github.com/fazilsheik96/android_bionic.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improve pty unit test to catch the bug more easily. 

Bug: http://b/69260651
Test: run bionic-unit-tests.

Change-Id: Ifb89cc2952508b6e5a093c57053fb93cb61cd28c
This commit is contained in:
Yabin Cui 2017-11-16 15:25:12 -08:00
parent 40a5cfa8d1
commit 57a4006c10
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tests/pty_test.cpp
View File

@ -112,7 +112,7 @@ TEST(pty, bug_28979140) {
GTEST_LOG_(INFO) << "This test tests bug happens only on multiprocessors."; GTEST_LOG_(INFO) << "This test tests bug happens only on multiprocessors.";
return; return;
} }
constexpr uint32_t TEST_DATA_COUNT = 200000; constexpr uint32_t TEST_DATA_COUNT = 2000000;
// 1. Open raw pty. // 1. Open raw pty.
int master; int master;
@ -149,11 +149,16 @@ TEST(pty, bug_28979140) {
ASSERT_EQ(0, sched_setaffinity(0, sizeof(cpu_set_t), &cpus)); ASSERT_EQ(0, sched_setaffinity(0, sizeof(cpu_set_t), &cpus));
// 4. Send data to slave. // 4. Send data to slave.
// Send a bunch of data at a time, so it is easier to catch the bug that some data isn't seen
// by the reader thread on another cpu.
uint32_t counter_buf[100];
uint32_t counter = 0; uint32_t counter = 0;
while (counter <= TEST_DATA_COUNT) { while (counter <= TEST_DATA_COUNT) {
ASSERT_TRUE(android::base::WriteFully(master, &counter, sizeof(counter))); for (size_t i = 0; i < sizeof(counter_buf) / sizeof(counter_buf[0]); ++i) {
counter_buf[i] = counter++;
}
ASSERT_TRUE(android::base::WriteFully(master, &counter_buf, sizeof(counter_buf)));
ASSERT_TRUE(arg.matched) << "failed at count = " << counter; ASSERT_TRUE(arg.matched) << "failed at count = " << counter;
counter++;
} }
ASSERT_EQ(0, pthread_join(thread, nullptr)); ASSERT_EQ(0, pthread_join(thread, nullptr));
ASSERT_TRUE(arg.finished); ASSERT_TRUE(arg.finished);