From 575129886c2db6c7ae1dfd2655d2053166049ad1 Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Mon, 2 Oct 2017 22:49:18 -0700 Subject: [PATCH] Pre-size the vector in the pthread_create ENOMEM test. Just to avoid the possibility of an unfortunate mmap occurring in order to grow the vector. Bug: N/A Test: ran tests Change-Id: I850740461d761916a0377272664159d010da7b84 --- tests/pthread_test.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/pthread_test.cpp b/tests/pthread_test.cpp index 46140bbc6..f342577a9 100755 --- a/tests/pthread_test.cpp +++ b/tests/pthread_test.cpp @@ -2117,8 +2117,9 @@ TEST(pthread, pthread_create__mmap_failures) { const auto kPageSize = sysconf(_SC_PAGE_SIZE); - // Use up all the VMAs. By default this is 64Ki. + // Use up all the VMAs. By default this is 64Ki (though some will already be in use). std::vector pages; + pages.reserve(64 * 1024); int prot = PROT_NONE; while (true) { void* page = mmap(nullptr, kPageSize, prot, MAP_ANON|MAP_PRIVATE, -1, 0);