Add getaddrinfo(3) tests for NULL arguments.

According to https://github.com/ukanth/afwall/pull/213 some OEMs have
shipped a getaddrinfo(3) that crashes given NULL hostnames.

Change-Id: I9cea5fdd68546b7c64cf47e10e2b2b4d672b69d0
This commit is contained in:
Elliott Hughes 2014-11-16 10:14:54 -08:00
parent 288fa03a5a
commit 32fea147ea
1 changed files with 17 additions and 0 deletions

View File

@ -21,6 +21,23 @@
#include <netdb.h>
#include <netinet/in.h>
TEST(netdb, getaddrinfo_NULL_host) {
// It's okay for the host argument to be NULL, as long as service isn't.
addrinfo* ai = NULL;
ASSERT_EQ(0, getaddrinfo(NULL, "smtp", NULL, &ai));
// (sockaddr_in::sin_port and sockaddr_in6::sin6_port overlap.)
ASSERT_EQ(25U, ntohs(reinterpret_cast<sockaddr_in*>(ai->ai_addr)->sin_port));
freeaddrinfo(ai);
}
TEST(netdb, getaddrinfo_NULL_service) {
// It's okay for the service argument to be NULL, as long as host isn't.
addrinfo* ai = NULL;
ASSERT_EQ(0, getaddrinfo("localhost", NULL, NULL, &ai));
ASSERT_TRUE(ai != NULL);
freeaddrinfo(ai);
}
TEST(netdb, getaddrinfo_NULL_hints) {
addrinfo* ai = NULL;
ASSERT_EQ(0, getaddrinfo("localhost", "9999", NULL, &ai));