From 125f1c0f224e2e50ea285ed184789765ce12feee Mon Sep 17 00:00:00 2001 From: Nick Kralevich Date: Tue, 14 Feb 2017 09:49:30 -0800 Subject: [PATCH] Add details on why AT_SYMLINK_NOFOLLOW is dangerous The comment isn't helpful as-is. Provide some clarifying information. Test: code compiles. No functional changes. Change-Id: I5267e0bc68857fdc8a4b3384a2a1b0d37693ee6e --- libc/bionic/faccessat.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/libc/bionic/faccessat.cpp b/libc/bionic/faccessat.cpp index 5f375e0f7..a86aeb2b6 100644 --- a/libc/bionic/faccessat.cpp +++ b/libc/bionic/faccessat.cpp @@ -45,6 +45,7 @@ int faccessat(int dirfd, const char* pathname, int mode, int flags) { if (flags != 0) { // We deliberately don't support AT_SYMLINK_NOFOLLOW, a glibc // only feature which is error prone and dangerous. + // More details at http://permalink.gmane.org/gmane.linux.lib.musl.general/6952 // // AT_EACCESS isn't supported either. Android doesn't have setuid // programs, and never runs code with euid!=uid. It could be