pa-fazil
/
android_bionic
mirror of https://github.com/fazilsheik96/android_bionic.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Don't even try to allocate 2GiB on LP32. 

std::vector will just throw std::length_error anyway...

Bug: http://b/241114825
Test: treehugger
Change-Id: I44a9be9a5357c7b3a1c1d1273ef90a023a91e81b
This commit is contained in:
Elliott Hughes 2022-08-02 18:25:22 +00:00
parent cede011a2c
commit 0cac2919fd
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tests/stdio_test.cpp
View File

@ -2940,28 +2940,38 @@ TEST(STDIO_TEST, freopen_null_filename_mode) {
fclose(fp); fclose(fp);
} }
#if defined(__LP64__)
static int64_t GetTotalRamGiB() { static int64_t GetTotalRamGiB() {
struct sysinfo si; struct sysinfo si;
sysinfo(&si); sysinfo(&si);
return (static_cast<int64_t>(si.totalram) * si.mem_unit) / 1024 / 1024 / 1024; return (static_cast<int64_t>(si.totalram) * si.mem_unit) / 1024 / 1024 / 1024;
} }
#endif
TEST(STDIO_TEST, fread_int_overflow) { TEST(STDIO_TEST, fread_int_overflow) {
#if defined(__LP64__)
if (GetTotalRamGiB() <= 4) GTEST_SKIP() << "not enough memory"; if (GetTotalRamGiB() <= 4) GTEST_SKIP() << "not enough memory";
const size_t too_big_for_an_int = 0x80000000ULL; const size_t too_big_for_an_int = 0x80000000ULL;
std::vector<char> buf(too_big_for_an_int); std::vector<char> buf(too_big_for_an_int);
std::unique_ptr<FILE, decltype(&fclose)> fp{fopen("/dev/zero", "re"), fclose}; std::unique_ptr<FILE, decltype(&fclose)> fp{fopen("/dev/zero", "re"), fclose};
ASSERT_EQ(too_big_for_an_int, fread(&buf[0], 1, too_big_for_an_int, fp.get())); ASSERT_EQ(too_big_for_an_int, fread(&buf[0], 1, too_big_for_an_int, fp.get()));
#else
GTEST_SKIP() << "32-bit can't allocate 2GiB";
#endif
} }
TEST(STDIO_TEST, fwrite_int_overflow) { TEST(STDIO_TEST, fwrite_int_overflow) {
#if defined(__LP64__)
if (GetTotalRamGiB() <= 4) GTEST_SKIP() << "not enough memory"; if (GetTotalRamGiB() <= 4) GTEST_SKIP() << "not enough memory";
const size_t too_big_for_an_int = 0x80000000ULL; const size_t too_big_for_an_int = 0x80000000ULL;
std::vector<char> buf(too_big_for_an_int); std::vector<char> buf(too_big_for_an_int);
std::unique_ptr<FILE, decltype(&fclose)> fp{fopen("/dev/null", "we"), fclose}; std::unique_ptr<FILE, decltype(&fclose)> fp{fopen("/dev/null", "we"), fclose};
ASSERT_EQ(too_big_for_an_int, fwrite(&buf[0], 1, too_big_for_an_int, fp.get())); ASSERT_EQ(too_big_for_an_int, fwrite(&buf[0], 1, too_big_for_an_int, fp.get()));
#else
GTEST_SKIP() << "32-bit can't allocate 2GiB";
#endif
} }
TEST(STDIO_TEST, snprintf_b) { TEST(STDIO_TEST, snprintf_b) {