StatiXOS
/
android_frameworks_base
forked from LeddaZ/frameworks_base
3
0
Fork 0
Code Pull Requests Activity

usb: Show charging notification only if power brick is disconnected 

On USB HIDL devices (qcom) and barely-implemented AIDL (older Pixels)
the power brick connection status is always POWER_BRICK_STATUS_UNKNOWN,
leading to charging notification showing up even while charging with a
wall charger.

Properly implemented USB AIDL [1] should report
POWER_BRICK_STATUS_DISCONNECTED when charging with anything other than
a wall charger (i.e SDP/PD), hence use this as the check instead.

[1]: 94bc87a6f2/usb/usb/Usb.cpp (785)

Fixes a13e377.

Change-Id: I9e251211e5801b2c1766a12bab7d4787c445dc14
This commit is contained in:
Adithya R 2024-01-15 08:22:28 +05:30 committed by yoriscape
parent 7252e94920
commit 53cbedbc8e
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
services/usb/java/com/android/server/usb/UsbDeviceManager.java
View File

@ -1543,7 +1543,8 @@ public class UsbDeviceManager implements ActivityTaskManagerInternal.ScreenObser
titleRes = com.android.internal.R.string.usb_charging_notification_title;
id = SystemMessage.NOTE_USB_CHARGING;
} else if (mSinkPower && mConnectedToDataDisabledPort
&& mPowerBrickConnectionStatus != UsbPortStatus.POWER_BRICK_STATUS_CONNECTED) {
&& mPowerBrickConnectionStatus ==
UsbPortStatus.POWER_BRICK_STATUS_DISCONNECTED) {
// Show charging notification when USB Data is disabled on the port, and not
// connected to a wall charger.
titleRes = com.android.internal.R.string.usb_charging_notification_title;